Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

From: Greg KH
Date: Wed Nov 28 2007 - 23:30:42 EST


On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote:
> While doing insert/remove (quickly) tests on USB, I managed to trigger
> an Oops on 2.6.23.1 on the call to strlen() in make_class_name().
>
> This patch prevents this oops.
>
> There is still the larger problem of the overall race
> that caused this in the first place, but much of the rest
> of the code in class.c appears to also do NULL checks to
> avoid Oops'ing, so this continues the tradition.
>
> Signed-off-by: Mark Lord <mlord@xxxxxxxxx>

As this is a bandage over the real problem, I'd prefer to not apply this
one right now until we find the root cause.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/