Re: [PATCH] Avoid overflows in kernel/time.c

From: Arjan van de Ven
Date: Thu Nov 29 2007 - 22:41:53 EST


On Thu, 29 Nov 2007 19:04:36 -0800
"H. Peter Anvin" <hpa@xxxxxxxxx> wrote:

> Chris Snook wrote:
> > H. Peter Anvin wrote:
> >> NOTE: This patch uses a bc(1) script to compute the appropriate
> >> constants.
> >
> > Perhaps dc would be more appropriate? That's included in busybox.
> >
>
> Perhaps it would, but I think there is more variability between dc
> implementations -- consider if the busybox version is broken, for
> eample.
>
> Either way, how many people compile their kernels in a busybox
> environment?
>
> Anyway, I don't think compiling bc is hard on anything which has a C
> compiler.

alternative is to just also ship the precomputed values ;-)

>
> -hpa
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


--
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/