Re: namespace support requires network modules to say "GPL"

From: Eric W. Biederman
Date: Sat Dec 01 2007 - 20:17:13 EST


Jiri Slaby <jirislaby@xxxxxxxxx> writes:

> On 12/02/2007 12:13 AM, Eric W. Biederman wrote:
>> Mark Lord <lkml@xxxxxx> writes:
>>> Fine. But all of them want to call sk_alloc(),
>>
>> network drivers should be calling sk_alloc less then they should
>> call dev_get_by_XXXX. Only protocols call sk_alloc.
>>
>>> and many want to do register_netdev().
>>
>> I haven't even touched register_netdev.
>>
>>> So what should they be using there ?
>>
>> What are you having problems with?
>>
>> It is hard to answer specific questions without a context.
>
> VMware vmnet.

With a quick glance in that direction it appears to the result
of a design bug in vmnet that they call sk_alloc at all, and someone
seems to have found a work around in vmnet for this situation.

My gut feel is that vmware should just use tun or tap (whichever
is the appropriate one), and be done with it.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/