Re: [PATCH] fix x86-32 early fixmap initialization.

From: Yinghai Lu
Date: Sat Dec 01 2007 - 21:25:15 EST


On Dec 1, 2007 5:34 PM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> pageexec@xxxxxxxxxxx writes:
>
> > hello,
> >
> > i've just noticed that the chunk in i386/kernel/head.S ended up in a
> > weird place, namely, it's not going to be executed as it's just after
> > a 'jmp 3f' and before startup_32_smp, probably not what you intended.
> > on a sidenote, the whole thing can be done in a single insn, like:
> >
> > movl $(swapper_pg_pmd - __PAGE_OFFSET + 0x067), (swapper_pg_dir -
> > __PAGE_OFFSET+ 4092)
> >
> > PS: your email address ebiderman@xxxxxxxxxxx in the commit seems to
> > be wrong as well.
>
> Yes. YH refresh one of my old patches and apparently got my email
> address wrong.
>
> Thanks for the reminder I thought we had fixed this problem a while ago.

i sent fix to andrew and andi. but it seems they missed it.

BTW: how about your head32.c patch series.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/