Re: 2.6.24-rc3-mm1 make headers_check fails

[Avi Kivity]

This is a multi-part message in MIME format.Andrew Morton wrote:
> On Wed, 21 Nov 2007 12:17:14 +0200 Avi Kivity <avi@xxxxxxxxxxxx> wrote:
>
>   
> > Avi Kivity wrote:
> >     
> > > > > > >   
> > > > > > >               
> > > > > > > > The make headers_check fails,
> > > > > > > >
> > > > > > > >  CHECK   include/linux/usb/gadgetfs.h
> > > > > > > >  CHECK   include/linux/usb/ch9.h
> > > > > > > >  CHECK   include/linux/usb/cdc.h
> > > > > > > >  CHECK   include/linux/usb/audio.h
> > > > > > > >  CHECK   include/linux/kvm.h
> > > > > > > > /root/kernels/linux-2.6.24-rc3/usr/include/linux/kvm.h requires 
> > > > > > > > asm/kvm.h, which does not exist in exported headers
> > > > > > > >                
> > > > > > > >                 
> > > > > > > hm, works for me, on i386 and x86_64.  What's different over there?
> > > > > > >            
> > > > > > >               
> > > > > > Hi Andrew,
> > > > > >
> > > > > > It fails on the powerpc box, with allyesconfig option.
> > > > > >
> > > > > >  
> > > > > >       
> > > > > >             
> > > > > How do we fix this?  Export linux/kvm.h only on x86?  Seems ugly.
> > > > >     
> > > > >           
> > > > Is kvm x86 specific? Then move the .h file to asm-x86.
> > > > Otherwise no good idea...
> > > >
> > > >   
> > > >         
> > > kvm.h is x86 specific today, but will be s390, ppc, ia64, and x86 
> > > specific tomorrow.
> > >
> > > What about having a asm-generic/kvm.h with a nice #error?    would 
> > > that suit?
> > >
> > >       
> > headers_check continues to complain.  Is the only recourse to add 
> > asm/kvm.h for all archs?
> >
> >     
>
> That would work.
>
> Meanwhile my recourse is to drop the kvm tree ;)
>   

Since you put it this way...

I committed the attached (sorry) patch to kvm.git.   Rather than 
touching 2*($NARCH - 1) file, I changed include/linux/Kbuild to only 
export kvm.h if the arch actually supports it.  Currently that's just x86.


--
error compiling committee.c: too many arguments to function