Re: Regression - 2.6.24-rc3 - umem nvram card driver oops

[Ingo Molnar]

* Neil Brown <neilb@xxxxxxx> wrote:

> ### Diffstat output
>  ./drivers/block/umem.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff .prev/drivers/block/umem.c ./drivers/block/umem.c
> --- .prev/drivers/block/umem.c	2007-12-04 11:11:30.000000000 +1100
> +++ ./drivers/block/umem.c	2007-12-04 11:11:42.000000000 +1100
> @@ -484,7 +484,8 @@ static void process_page(unsigned long d
>  		page->idx++;
>  		if (page->idx >= bio->bi_vcnt) {
>  			page->bio = bio->bi_next;
> -			page->idx = page->bio->bi_idx;
> +			if (page->bio)
> +				page->idx = page->bio->bi_idx;
>  		}
>  
>  		pci_unmap_page(card->dev, desc->data_dma_handle,

btw., if anyone feels so inclined, this file has quite a number of 
coding style issues, as per scripts/checkpatch.pl output:

 total: 28 errors, 54 warnings, 1221 lines checked

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/