Re: [patch 1/3] driver core: Introduce default attribute groups.

From: Greg KH
Date: Wed Dec 05 2007 - 11:23:41 EST


On Wed, Dec 05, 2007 at 12:50:23PM +0100, Cornelia Huck wrote:
> This is lot like default attributes for devices (and indeed,
> a lot of the code is lifted from there).
>
> Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
>
> ---
> drivers/base/driver.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
> include/linux/device.h | 2 ++
> 2 files changed, 45 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/base/driver.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/driver.c 2007-12-05 09:53:15.000000000 +0100
> +++ linux-2.6/drivers/base/driver.c 2007-12-05 12:41:02.000000000 +0100
> @@ -151,6 +151,39 @@ void put_driver(struct device_driver * d
> kobject_put(&drv->p->kobj);
> }
>
> +static int driver_add_groups(struct device_driver *drv,
> + struct attribute_group **groups)

Heh, I just added a driver_add_group() function, to fix up some other
ppc driver :)

I'll delete that and use this series instead, it's nicer.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/