Re: Patch submission question [not in the FAQ]

From: Jan Engelhardt
Date: Thu Dec 06 2007 - 10:01:52 EST



On Dec 5 2007 03:36, Gabriele Gorla wrote:
>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
> unsigned char padding[12];
> } TW_Passthru;
>
>+#pragma pack()
>+
> typedef struct TAG_TW_Device_Extension {
> u32 base_addr;
> unsigned long
>*alignment_virtual_address[TW_Q_LENGTH];
>@@ -430,6 +432,4 @@ typedef struct
>TAG_TW_Device_Extension {
> wait_queue_head_t ioctl_wqueue;
> } TW_Device_Extension;
>
>-#pragma pack()
>-

Hmpf. Can't you __attribute__((packed))-ify the structs rather
than use #pragma?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/