Re: [PATCH] Fake NUMA emulation for PowerPC

[Dave Quigley]

On Fri, 2007-12-07 at 22:30 +0100, Geert Uytterhoeven wrote:
> On Sat, 8 Dec 2007, Balbir Singh wrote:
> > +	if (strstr(p, "fake="))
> > +		cmdline = p + 5;	/* 5 is faster than strlen("fake=") */
> 
> Really? My gcc is smart enough to replace the `strlen("fake=")' by 5, even
> without -O.

If some odd reason it doesn't replace it wouldn't it be smarter to do
sizeof("fake="); It should definitely optimize that away to a constant
value and its less prone to error if the string in strstr changes.

> 
> With kind regards,
>  
> Geert Uytterhoeven
> Software Architect
> 
> Sony Network and Software Technology Center Europe
> The Corporate Village  Da Vincilaan 7-D1  B-1935 Zaventem  Belgium
>  
> Phone:    +32 (0)2 700 8453	
> Fax:      +32 (0)2 700 8622	
> E-mail:   Geert.Uytterhoeven@xxxxxxxxxxx	
> Internet: http://www.sony-europe.com/
>  	
> Sony Network and Software Technology Center Europe	
> A division of Sony Service Centre (Europe) N.V.	
> Registered office: Technologielaan 7  B-1840 Londerzeel  Belgium	
> VAT BE 0413.825.160 Â RPR Brussels	
> Fortis Bank Zaventem  Swift GEBABEBB08A  IBAN BE39001382358619

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/