Re: [PATCH] mmc: remove unused 'mode' from the mmc_host structure

[Pierre Ossman]

On Thu, 06 Dec 2007 23:12:46 -0500 (EST)
Nicolas Pitre <nico@xxxxxxx> wrote:

> This field and corresponding defines are simply never used anywhere
> in the code.  But its mere presence is enough to confuse some host 
> driver authors who attempt to rely on it.  Let's eliminate the 
> possibility for confusion and remove it entirely.
> 
> Signed-off-by: Nicolas Pitre <nico@xxxxxxx>
> ---

Oopsie. Some old stuff since before the restructuring.

> 
> yes, it's the second host driver I'm reviewing with this issue...
> 

Seems to be a bit of Windows mentality that spills over. Maybe you should give them a quick tutorial in that in Linux we fix stuff at the source. ;)

Thanks for the patch. I've queued it up.

Rgds
Pierre

Attachment: signature.asc
Description: PGP signature