Re: scsi/lpfc/lpfc_attr.c: bogus code

From: James Smart
Date: Wed Dec 12 2007 - 17:01:24 EST


This has already been fixed. It's in our 8.2.3 patches, which were merged into
James's scsi-misc-2.6 tree at the beginning of November, and targeted for 2.6.25.

-- james s


Adrian Bunk wrote:
Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code:

<-- snip -->

...
lpfc_state_show(struct class_device *cdev, char *buf)
{
...
switch (vport->port_state) {
len += snprintf(buf + len, PAGE_SIZE-len,
"initializing\n");
break;
...

<-- snip -->

Spotted by the GNU C compiler version 3.3.

cu
Adrian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/