Re: [PATCH -mm] x86 boot : export boot_params via sysfs (forwardto Greg)

From: Greg KH
Date: Wed Dec 12 2007 - 17:30:44 EST


On Wed, Dec 12, 2007 at 02:15:35PM -0500, Dave Jones wrote:
> On Wed, Dec 12, 2007 at 09:45:07AM -0800, Greg Kroah-Hartman wrote:
>
> > Well, I respectively disagree. sysfs is NOT for exporting various
> > binary kernel structures to userspace directly. Again, the binary files
> > in sysfs are for chunks of memory that are PASS-THROUGH from hardware to
> > userspace, with no kernel intervention at all.
> > If you really need such a thing, use debugfs, as the only rule for
> > debugfs is that there is no rules :)
>
> Whilst on the subject, why wasn't /sys/slab done in debugfs ?
> The one-value-per-file thing has gone taken to ridiculous extremes there.

Heh, I think most of those files only show up if you have
CONFIG_SLUB_DEBUG enabled, and it's easier to add them to the original
sysfs entries instead of creating new debugfs ones.

> Having 3641 sysfs files that most people never use permanently taking up
> memory seems to be a massive waste of resources.

sysfs files have their dentries and inodes pushed out of memory if they
are never accessed, so no huge ammounts of memory are used here.

Otherwise we would never be able to support 20,000 block devices on a
31bit s390 with 128Mb of ram :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/