Re: [PATCH] Mark timer_stats as incompatible with multiple pidnamespaces

From: Ingo Molnar
Date: Thu Dec 13 2007 - 15:26:51 EST



* Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:

> > the problem is, this interface stores historic PIDs too - i.e. PIDs
> > of tasks that might have exited already.
>
> Well struct pid * works in that case if you grab the reference to it.

but the display of the stats might happen much later. The point of this
API is to save pid+comm, which gives users a good idea about what caused
the events in the past - without having to pin any resource of that
task.

> {
> timer->start_site = NULL;
> + pit_pid(timer->start_pid);
> + timer->start_pid = NULL;

s/pit/put, right?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/