Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

[Andi Kleen]

On Fri, Dec 14, 2007 at 05:35:13PM -0500, Chuck Ebbert wrote:
> On 12/14/2007 05:17 AM, Andi Kleen wrote:
> >> so do whatever is necessary to enable dynticks. 
> > 
> > dynticks' main purpose is to save power, but C1e saves more power.
> > Disabling C1e for dynticks would be a fairly useless default
> > trade off.
> > 
> 
> What about machines where the BIOS has disabled C1e on CPU 0 but
> left it enabled on CPU 1 ??

It's a BIOS bug.  We handle this and threat it like C1e always enabled.

The right fix would be to enable it on both CPUs, but 
then that's not strictly needed for correct operation and I'm not
sure it would be worth special fixup code in Linux. Probably not.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/