Re: [PATCH 7/21] [PATCH] unify common parts of processor.h

From: Glauber de Oliveira Costa
Date: Tue Dec 18 2007 - 07:08:08 EST


Ingo Molnar wrote:
* Glauber de Oliveira Costa <gcosta@xxxxxxxxxx> wrote:

This patch moves the pieces of processor_32.h and processor_64 that are equal to processor.h. Only what's exactly the same is moved around, the rest not being touched.

argh, it doesnt even build cleanly:

In file included from include/linux/elf.h:6,
from include/linux/module.h:14,
from include/linux/crypto.h:21,
from arch/x86/kernel/asm-offsets_32.c:7,
from arch/x86/kernel/asm-offsets.c:2:
include/asm/elf.h:286: warning: 'struct mm_struct' declared inside parameter list
include/asm/elf.h:286: warning: its scope is only this definition or declaration, which is probably not what you want

due to zapping this bit of include/asm-x86/processor_32.h:

-/* Forward declaration, a strange C thing */
-struct task_struct;
-struct mm_struct;

Ingo

I'll test it with your config, and repost.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/