Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

From: Grant Likely
Date: Thu Dec 20 2007 - 01:30:29 EST


On 12/19/07, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> From: Grant Likely <grant.likely@xxxxxxxxxxxx>
>
> Please review and comment. This patch works in my setup, but I haven't
> tested exhaustively yet. I also need to fixup the documentation to
> reflect new states before I request this patch to be merged.
>
> Question for the block layer experts: I'm using add_disk()/del_gendisk()
> functions to inform the kernel of media insertion and removal events. Is
> this the best way to do this? I looked at the .media_changed and
> .revalidate_disk hooks, but it doesn't seem like they offer the driver
> any way to notify the kernel of media removal (as opposed to the kernel
> asking the driver)

Heh, actually I *know* I'm doing the wrong thing; but I'm hoping I've
got better chances of getting steered in the right direction if I
start by throwing code out there. Currently this patch handles
insertion/removal just fine if nothing is mounted, but gets stuck if
the disk is in use. How do I get the kernel to cancel all pending
requests when deregistering the device?

Thanks,
g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@xxxxxxxxxxxx
(403) 399-0195
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/