Re: [PATCH 1/5] power: RFC: introduce a new power API

From: Anton Vorontsov
Date: Thu Dec 20 2007 - 12:08:01 EST


On Thu, Dec 20, 2007 at 11:00:30AM -0500, Andres Salomon wrote:
> On Thu, 20 Dec 2007 18:07:16 +0300
> Anton Vorontsov <cbou@xxxxxxx> wrote:
>
> > Hi Andres,
> >
> [...]
> >
> > Then, what the power supply subsystem is for? Just place all the
> > drivers together in driver/power/, and let them create sysfs
> > attributes by their own. You'll get a medley, not the subsystem.
> >
> > Good luck,
> >
>
>
> Ok, I'm really tired of arguing about this.

Me either, you wouldn't believe.

> I've pointed out why
> the current API is inadequate, but you seem to be resisting
> changing it.

No, you didn't point out anything. You didn't describe _why_ you
want to change the subsystem. No single reason except "flexibility"
that _no one_ is using.

> It's your subsystem, do what you like.

No, this isn't mine subsystem. I've written most of it, probably.
But now I'm just volunteering to co-maintain it (that is, the person
whom to blame if something goes wrong in power/). I'm also directly
interested in this subsystem, because I have the hardware on which
I'm using it.

But I'm not the last person you can ask to merge your changes. Whole
LKML is hearing us, and if you want to--ask David to push your
changes over me. Or Andrew. Or ask Linus at the last. They're are
much better programmers than I am, so whatever they'll do would be
the right thing. I'll just swallow it.

Though, on the current patches, please stamp my:

Nacked-by: Anton Vorontsov <cbou@xxxxxxx>

so the history will have written evidence that I did not agree on
the changes, so years later I could reply to the complaints: "Look,
I nacked this code, it wasn't me who checked this in!"


You have another option though: finally show up the user of the
purposed changes. Without single "flexible" word, please. Real,
existent user.

--
Anton Vorontsov
email: cbou@xxxxxxx
backup email: ya-cbou@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/