Re: [PATCH 0/4] add task handling notifier

From: Ingo Oeser
Date: Thu Dec 20 2007 - 17:22:42 EST


Hi Jan,

I like and support your idea!

On Thursday 20 December 2007, Jan Beulich wrote:
> With more and more sub-systems/sub-components leaving their footprint
> in task handling functions, it seems reasonable to add notifiers that
> these components can use instead of having them all patch themselves
> directly into core files.

Yes, but why export variables? Wouldn't it be better to export
an API?

That simplifies the callers (they all pass "current" as task
and "task_notifier_list" as arguments).

It also prevents exposing internal variables (notifier lists
ARE internal variables) to modules.

What do you think?


Best Regards

Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/