Re: [PATCH] x86: kprobes remove fix_riprel #ifdef

[Masami Hiramatsu]

Ingo Molnar wrote:
> * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> 
>> Indeed.
>> By the way, flush_cache_page() is defined as a do-while(0) on x86.
>> Would it better to define fix_riprel() as a do-while(0) on x86-32?
>> I think this obviously indicates that function has no effect.
> 
> NOPs should always be an inline. flush_cache_page()'s macro use is 
> historic - feel free to send cleanup patches against cacheflush.h.

OK, in that case, harvey's patch is good to me.

> or even better, since most architectures dont need explicit 
> cache-flushes, provide an asm-generic/cache_flush-nop.h file that is
> #include-ed by asm-x86/cacheflush.h. (and by other architectures)
> 
> 	Ingo

Thanks,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/