Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

[Rene Herman]

On 30-12-07 22:44, H. Peter Anvin wrote:
> Ingo Molnar wrote:
> > > >
> > > It probably should actually HLT, to avoid sucking power, and 
> > > stressing the thermal system.  We're dead at this point, and the 
> > > early 486's which had problems with HLT will lock up - we don't care.
> >
> > ok. Like the patch below?
>
> Don't need the cli; we're already running with interrupts disabled.
>
> I'd do:
>
>     while (1)
>         asm volatile("hlt");
>
> ... mostly on general principles.

At least with current GCC the volatile isn't strictly needed as its implied 
without output operands but I was only certain after checking that. Do you 
remember if that used to be different for previous GCC versions? I tend to 
also stick volatiles on them still...

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/