Re: asm-x86/msr.h for sanitized headers: clean it or punt it

From: Andi Kleen
Date: Mon Dec 31 2007 - 07:27:07 EST


Mike Frysinger <vapier@xxxxxxxxxx> writes:

> The current asm-x86/msr.h does not actually define anything for (!__KERNEL__
> && __i386__). For x86_64, it fails to build due to u32/u64 types being used.
> Simply not installing the header seems easiest to me. Otherwise, x86_64 will
> need sanitizing and i386 should have things added back, otherwise it's just a
> pointless empty header.

Please don't -- asm/msr.h is very useful in user space for rdtscll et.al.
I use it all the time in test programs.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/