Re: asm-x86/byteorder.h: clean up for userspace

From: H. Peter Anvin
Date: Tue Jan 01 2008 - 16:24:32 EST


Christoph Hellwig wrote:
On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote:
Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than
asm in its code.

The correct fix is to not export it to userspace.

Unfortunately, it's historically been provided, for over 15 years. It's also trivial to export, without funnies, and it's *useful* to userspace, as it provides an interface sorely lacking from the stock libc interfaces.

So please do provide it, even though it's arguably the wrong thing. The downside is worse.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/