Re: [PATCH 1/3] ide: use MODULE_VERSION()

From: Jon Masters
Date: Tue Jan 01 2008 - 21:33:27 EST


On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote:

> On the second thought: maybe we will be better off with limiting
> MODULE_VERSION() to the device drivers and the IDE core module for now,
> and just removing all these private version numbers from host drivers
> (with one or two exceptions they are not printed or exported currently,
> moreover exceptions are the cases like stale version numbers from 199x)?

Things like checkpatch could help advise people to bump the version
number, but it's a bit iffy. Matt D. actually uses the special source
version modinfo for DKMS - which is different - but it makes me wonder
whether dynamically generating a version based on source SHA1 wouldn't
be a better idea in most cases than an outdated hard-coded one.

Comments?

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/