Re: [patch 1/3] move WARN_ON() out of line

From: Pekka Enberg
Date: Thu Jan 03 2008 - 06:20:29 EST


Hi Arjan,

On Jan 3, 2008 2:56 AM, Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:
> +int do_warn_on(const unsigned long condition, const char *file,
> + const int line, const char *function)
> +{
> + if (unlikely(condition)) {
> + printk(KERN_WARNING "WARNING: at %s:%d %s()\n",
> + __FILE__, __LINE__, __FUNCTION__);

I don't think you want to use __FILE__ and friends here...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/