Re: [PATCH 19/24] udf: check if udf_load_logicalvol failed

From: Marcin Slusarz
Date: Mon Jan 07 2008 - 14:18:21 EST


On Mon, Jan 07, 2008 at 12:29:51PM +0100, Jan Kara wrote:
> On Sun 23-12-07 02:51:09, marcin.slusarz@xxxxxxxxx wrote:
> > udf_load_logicalvol may fail eg in out of memory conditions - check it
> > and propagate error further
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> > CC: Ben Fennema <bfennema@xxxxxxxxxxxxxxxxxxxxxx>
> > CC: Jan Kara <jack@xxxxxxx>
> I certainly agree with the idea of the change. Just note that
> udf_process_sequence() returns 1 in case of failure so propagating an error
> is not ideal - we should keep things consistent. And also note that the
> actual value is disregarded in udf_load_partition() anyway.
OK, I will make it consistent in next version.

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/