Re: [PATCH] call sysrq_timer_list_show from a workqueue

From: Ingo Molnar
Date: Tue Jan 08 2008 - 06:34:04 EST



* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> +/* FIXME: Risky: returns a pointer into a module w/o lock */

stupid question: since module unloads are so rare, why isnt this via the
same mechanism that CPU hotplug uses to securely unregister CPUs? I.e.
quiet all CPUs, disable irqs on all of them, then unlink the module.
This would make module unload fundamentally safe, and symbols could be
looked up lockless. (with the exception of crashing within NMIs, but
that is not lock safe anyway.)

Or is this a rathole for some reason?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/