Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
>   
> >  #define __PAGE_KERNEL_EXEC						\
> > -	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_GLOBAL)
> > +	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED)
> >     

This shouldn't be necessary.  The old 64-bit code defined everything 
without _PAGE_GLOBAL, but then used a MAKE_GLOBAL() macro to OR it in 
later.  This seemed a bit roundabout to me, so I just put it in from the 
outset.

> btw., __PAGE_KERNEL_EXEC should probably be _PAGE_GLOBAL - but it wasnt 
> before.
>   

You mean _PAGE_KERNEL_EXEC, which is assigned to the 32-bit 
__PAGE_KERNEL_EXEC variable?  It gets ORed in when it determines that 
the processor has the global capability.

If not, I'm not sure what you mean.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/