Re: More breakage in native_rdtsc out of line in git-x86

From: Andi Kleen
Date: Wed Jan 09 2008 - 10:49:07 EST


On Wed, Jan 09, 2008 at 04:22:08PM +0100, Ingo Molnar wrote:
>
> * Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> > > nope, it's a 64-bit setup/dependency bug/problem: the vsyscall mappings
> > > are installed via an __initcall, and that's too late for early use. The
> > > combo patch below fixed the crash for me, does it work on your box too?
> >
> > That gives
> >
> > /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c: In function 'setup_arch':
> > /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c:468: error: implicit declarati
> > on of function 'map_vsyscall'
>
> i guess you have an old repository.

I just applied the patch you sent out against yesterday's git-x86.

>
> > But after I add a prototype to vsyscall.h it seems to work.
> >
> > Just the barriers are still broken [...]
>
> since yesterday there's a full barrier around rdtsc.

Great.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/