Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

From: YOSHIFUJI Hideaki / 吉藤英明
Date: Sat Jan 12 2008 - 00:47:49 EST


Hello.

In article <20080108011057.GA21168@xxxxxxxxx> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <vaf@xxxxxxxxx> says:

> #define IN_MULTICAST_NET 0xF0000000
>
> +#define IN_CLASSE(a) ((((long int) (a)) & 0xf0000000) == 0xf0000000)
> +#define IN_CLASSE_NET 0xffffff00
> +#define IN_CLASSE_NSHIFT 8
> +#define IN_CLASSE_HOST (0xffffffff & ~IN_CLASSE_NET)
> +
> +/*
> + * these are no longer used
> #define IN_EXPERIMENTAL(a) ((((long int) (a)) & 0xf0000000) == 0xf0000000)
> #define IN_BADCLASS(a) IN_EXPERIMENTAL((a))
> +*/

Please do not remove this, but have these instead:

#define IN_EXPERIMENTAL(a) IN_CLASSE((a))
#define IN_BADCASS(a) IN_CLASSE((a))

And, I think it is good to remove BADCLASS() (inside
#ifdef __KERNEL__ .. #endif) because we do not have its users
any longer, right?

Regards,

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/