Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16

[Jan Engelhardt]

On Jan 13 2008 10:34, travis@xxxxxxx wrote:
>--- a/arch/x86/kernel/mpparse_64.c
>+++ b/arch/x86/kernel/mpparse_64.c
>@@ -132,7 +132,7 @@ static void __cpuinit MP_processor_info(
> 	 * area is created.
> 	 */
> 	if (x86_cpu_to_apicid_ptr) {
>-		u8 *x86_cpu_to_apicid = (u8 *)x86_cpu_to_apicid_ptr;
>+		u16 *x86_cpu_to_apicid = (u16 *)x86_cpu_to_apicid_ptr;
> 		x86_cpu_to_apicid[cpu] = m->mpc_apicid;
> 	} else {
> 		per_cpu(x86_cpu_to_apicid, cpu) = m->mpc_apicid;

You can do away with the cast while modifying this line.

>--- a/arch/x86/mm/srat_64.c
>+++ b/arch/x86/mm/srat_64.c
>@@ -384,6 +388,12 @@ int __init acpi_scan_nodes(unsigned long
> }
> 
> #ifdef CONFIG_NUMA_EMU
>+static int fake_node_to_pxm_map[MAX_NUMNODES] __initdata = {
>+	[0 ... MAX_NUMNODES-1] = PXM_INVAL
>+};
>+static unsigned char fake_apicid_to_node[MAX_LOCAL_APIC] __initdata = {
>+	[0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
>+};
> static int __init find_node_by_addr(unsigned long addr)
> {
> 	int ret = NUMA_NO_NODE;

No u8/u16 here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/