Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM withoutHOTPLUG_CPU

From: Adrian Bunk
Date: Mon Jan 14 2008 - 13:18:22 EST


On Mon, Jan 14, 2008 at 03:58:54PM +0100, Ingo Molnar wrote:
>...
> a good way i see is to:
>...
> - quickly reach a close-to-100%-perfect stage, brute-force. Drop
> __init* annotations en masse if they are not perfectly layered.
> Whoever reintroduces them will then have to do it perfectly.
>...

First of all, this would really hurt space limited systems.

And "whoever reintroduces them" will most likely mean in practice that
some janitors will go through the code and you as a maintainer will
anyway be busy with getting them in shape.

Let's get them rightonce and we have a reasonable status quo.

> Ingo

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/