Re: thinkpad_acpi: define _sta only when needed

From: Johannes Weiner
Date: Wed Jan 16 2008 - 16:09:38 EST


Hi Henrique,

Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> writes:

> On Wed, 16 Jan 2008, Johannes Weiner wrote:
>> Define _sta() helper conditionally; also remove its prototype from
>> the internal header and also some other unneeded ones.
>>
>> This function is only needed when the bay or the dock subdriver is
>> enabled. Otherwise, gcc complains about an unused static function.
>
> Johannes, thanks for the patches, but NAK. A similar group of patches that
> clean up the _sta and heander file (kills it, actually) has already been
> sent to Len Brown to be merged for 2.6.25.

Sorry, I missed to check his tree in advance. And if the work is
already done - even better! :)

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/