Re: [PATCH 9/10] introduce intel_menlow platform specific driver

From: Randy Dunlap
Date: Thu Jan 17 2008 - 15:52:41 EST


Len Brown wrote:
+static int
+memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev,
+ unsigned long *max_state)
Don't put 'static int' (return type etc.) on a line by itself.
That format is not wanted in Linux. (many places here)

if checkpatch.pl and Lindent are happey (which they are not, totally)
then I'm satisifed witht he Linux style of the code.

Randy, if you feel strongly about this this style nit,
then change Lindent to implement it -- nagging
developers about trivia is a waste of everybody's time.

thanks,
-Len

http://marc.info/?l=linux-kernel&m=105451996829576&w=2

Thanks.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/