Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_attr patch series v3)

[Andi Kleen]

On Friday 18 January 2008 17:07:57 Ingo Molnar wrote:
> 
> * Andi Kleen <ak@xxxxxxx> wrote:
> 
> > > could you please make your queue bisectable?
> > 
> > The idea was that you git revert the original patches I referenced and 
> > then drop the undo patches since I reimplement all that in different 
> > ways (except for the white space changes, but that can be redone once 
> > everything settled down again). Then it will be bisectable.
> 
> and how does that again make things bisectable in the middle of the PAT 
> queue? For example if i undo:
> 
>   Subject: x86: pat: cpa, 32-bit
>   From: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
>

Ok sorry only the pageattr_32 hunks would need to be undone.

So it would be something like:

drop venki's 32bit patch
insert my patch to add cpa_addr()
reinsert venki's patch with the pageattr_32 hunks dropped after it

drop venki's 64bit patch
insert my patch to add reserved checking on 64bit cpa
reinsert venki's patch with the pageattr_64 hunks dropped after it

The result should be bisectable.

> > (except for the white space changes, but that can be redone once 
> > everything settled down again). Then it will be bisectable.
> 
> it's a revert barrier (within v2.6.25),

What is a revert barrier?

Anyways of course the way to handle that is the same as with the other undo
patches: drop the original white space changes (ddb53b5735793a19dc17bcd98b050f672f) 
completely and then drop that undo patch too. The white space changes haven't reached 
Linus yet so you can just make them disappear completely from known history.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/