Re: [PATCH] [5/7] Remove CONFIG_X86_TSC for 32bit II

From: Ingo Molnar
Date: Fri Jan 18 2008 - 17:06:54 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Andi Kleen <ak@xxxxxxx> writes:
>
> > The config option protects so little code that it is fairly pointless.
> > Also a lot of its code was related to itself only (as in panicing without
> > TSC). And TSC less CPUs are completely handled at runtime anyways.
> >
> > This makes 32bit behaviour match x86-64.
> >
> > I also removed an #if defined(CONFIG_X86_GENERIC) in get_cycles. Not
> > sure what that was good for, it didn't make any sense.
>
> Hmm, during further testing i found that the patch causes boot
> failures in some configuration. I withdraw this one for now.

ok, pulled. In what situations did it fail? It worked fine on a (small)
number of systems here.

> The other patches in the series are independent and should be still
> considered for merging.

yep, they are in and have caused no problems so far.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/