Re: [PATCH 3/4] introduce __devinitconst

[Greg KH]

On Fri, Jan 11, 2008 at 01:57:27AM -0700, Jan Beulich wrote:
> The drivers picked just serve as examples (which I routinely build and
> hence am able to easily verify), i.e. as before he patch doesn't change
> all instances where 'const' could have been added as a result of the
> base change, only where the change has a real effect (the module loader
> doesn't enforce read-only section attributes at present, so only
> built-in files make a real difference).

What does this buy us?

> --- 2.6.24-rc7-initconst.orig/include/linux/init.h
> +++ 2.6.24-rc7-initconst/include/linux/init.h
> @@ -257,11 +257,13 @@ void __init parse_early_param(void);
>  #ifdef CONFIG_HOTPLUG
>  #define __devinit
>  #define __devinitdata
> +#define __devinitconst const
>  #define __devexit
>  #define __devexitdata
>  #else
>  #define __devinit __init
>  #define __devinitdata __initdata
> +#define __devinitconst __initdata

Shoudn't that be "__initdata const" or something like that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/