Re: [PATCH] [7/8] CPA: Implement GBpages support inchange_page_attr()

From: Ingo Molnar
Date: Sat Jan 19 2008 - 13:53:45 EST



* Andi Kleen <ak@xxxxxxx> wrote:

> arch/x86/mm/pageattr_64.c | 150
> ++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 119 insertions(+), 31 deletions(-)

please unify the files first, we dont want to let pageattr_32.c and
pageattr_64.c diverge even more. Once we get these files unified we
layer more features ontop of it. While gbpages is not available on
32-bit and probably wont ever be, this code has been historically very
fragile, so having a single codebase to look at is very important.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/