Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

[Matthew Wilcox]

On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote:
> In a nutshell, printk_header() lets you do the following atomically
> (against other messages).
> 
>  code:
>   printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n");
> 
>  output:
>   <6>ata1.00: line0
>   <6>         line1
>   <6>         line2

I think this is a really bad idea.  It's much better to have:

<6>ata1.00: line0
<6>ata1.00: line1
<6>ata1.00: line2

That way you can grep for ata1.00 and get all messages relevant to that
device.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/