Re: [PATCH 19/26] atl1: modernize down/up functions

[Jeff Garzik]

jacliburn@xxxxxxxxxxxxx wrote:
> From: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
>
> Update atl1_down() and atl1_up() to conform with the current vendor driver
> version 1.2.40.2.
>
> Signed-off-by: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
> ---
>  drivers/net/atlx/atl1.c |   21 ++++++++-------------
>  drivers/net/atlx/atl1.h |    1 -
>  drivers/net/atlx/atlx.c |    2 +-
>  3 files changed, 9 insertions(+), 15 deletions(-)

same comments continue...  these are software changes that need to be 
explained.

"conform with vendor driver" does not excuse failure to document changes 
in init and shutdown sequencing, for example.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/