Re: [PATCH] Missing usb_find_device symbol from usb.c

From: Adrian Bunk
Date: Tue Jan 22 2008 - 17:09:41 EST


On Tue, Jan 22, 2008 at 08:18:32PM +0100, Wilco Beekhuizen wrote:

> 2.6.24-rc8 (possibly lower rc's too) has usb_find_device removed from
> usb.c. This causes problems when compiling modules that need
> usb_find_device.
> This patch puts the symbol back in place. Unless someone has a good
> reason not to include usb_find_device?
>...

The good reason is that there is no longer any in-kernel user of this
export, and the kernel does not offer APIs only for external modules.

If there's no in-kernel users that's also a light indication that it
might not be the correct API to use.

Tell the vendors of the modules using it that they should submit their
modules for inclusion in the kernel.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/