Re: [PATCH -v8 3/4] Enable the MS_ASYNC functionality insys_msync()

From: Miklos Szeredi
Date: Wed Jan 23 2008 - 16:16:54 EST


> So it's not horribly hard, but it's kind of a separate issue right now.
> And while the *generic* page-writeback is easy enough to fix, I worry
> about low-level filesystems that have their own "writepages()"
> implementation. They could easily get that wrong.

Yeah, nasty.

How about doing it in a separate pass, similarly to
wait_on_page_writeback()? Just instead of waiting, clean the page
tables for writeback pages.

> So right now it seems that waiting for writeback to finish is the right
> and safe thing to do (and even so, I'm not actually willing to commit my
> suggested patch in 2.6.24, I think this needs more thinking about)

Sure, I would have though all of this stuff is 2.6.25, but it's your
kernel... :)

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/