Re: [PATCH 1/2] x86: GEODE fix MFGPT input clock value

From: H. Peter Anvin
Date: Wed Jan 23 2008 - 17:23:38 EST


Willy Tarreau wrote:
Hi Peter,

On Wed, Jan 23, 2008 at 01:59:32PM -0800, H. Peter Anvin wrote:
Willy Tarreau wrote:
The GEODE MFGPT code assumed that 32kHz was 32000 Hz while the boards
run on a 32.768 kHz digital watch crystal. In practise, it will not
change the timer's frequency as the skew was only 2.4%, but it
should provide more accurate intervals.
- * Divisor Hz Min Delta (S) Max Delta (S)
Seconds are "s", not "S" (S = siemens.)

You're quite right. Same as we should write kHz and not Khz. But I'm
used to change other people's work and particularly comments the least
possible. Do you want an update ?


I much prefer to see this done right. I have a pretty case-sensitive brain, it seems.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/