Re: [PATCH -v8 3/4] Enable the MS_ASYNC functionality in sys_msync()

[Hugh Dickins]

On Wed, 23 Jan 2008, Linus Torvalds wrote:
> On Wed, 23 Jan 2008, Miklos Szeredi wrote:
> 
> > Sure, I would have though all of this stuff is 2.6.25, but it's your
> > kernel... :)
> 
> Well, the plain added "file_update_time()" call addition looked like a 
> trivial fix, and if there are actually *customers* that have bad backups 
> due to this, then I think that part was worth doing. At least a "sync" 
> will then sync the file times...

Fair enough.

Something I dislike about it, though, is that it leaves the RAM-backed
filesystems (ramfs, tmpfs, whatever) behaving visibly differently from
the others.  Until now we've intentionally left them out of syncing and
dirty accounting, because it's useless overhead for them (one can argue
whether that's quite true of tmpfs overflowing out to swap, but that's
a different debate).  So they won't be getting these faults on shared
writable, so their file times won't get updated in the same way.

But I guess that's an aesthetic consideration, of less significance
than bad backups - assuming not many people use backups of tmpfs.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/