Re: [PATCH] [KGDB] core code cleanups

From: Andrew Morton
Date: Sun Jan 27 2008 - 01:02:31 EST


> On Fri, 25 Jan 2008 23:28:36 +0100 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Jason Wessel <jason.wessel@xxxxxxxxxxxxx> wrote:
>
> > This patch is against the x86-git which included the kgdb core.
> >
> > Per review request from the x86-git maintainers, the kgdb-core has had
> > the kgdb_handle_exception() separated into individual functions. This
> > patch does nothing other than re-organize the code. There are no
> > functional kgdb changes.
> >
> > kgdb_handle_exception now calls gdb_serial_stub() to handle the
> > debugger communications. The gdb_serial_stub() has call out to sub
> > handlers for all the major gdb serial packet types.
>
> thanks Jason, i have applied your cleanups to x86.git.
>

I don't recall having actually seen the kgdb patches recently. Have they
had a suitable level of review?

In particular, as the plan is to migrate all kgdb-enabled architectures
onto the generic kgdb core (yes?), have the owners of the eligible
architectures actually taken a look at what we'll be asking of them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/