Re: [PATCH] Rationalise ACPI backlight implementation

From: Matthew Garrett
Date: Mon Jan 28 2008 - 00:28:43 EST


On Sun, Jan 27, 2008 at 09:10:13PM -0800, Andrew Morton wrote:

> You cannot seriously tell me that if we are to change this range from 0-8
> up to 0-100 then this is not a backwards-incompatible change in
> semantics.

We're talking about changing 0-100 to 0-something sane, because the
current driver is quite clearly broken. And yes, I'm perfectly happy to
say that - the reason that max_brightness is exported is to allow
userspace to determine what range of values is acceptable, and if
userspace ignores that then things are going to break for it at some
point.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/