Re: [PATCH] Deprecate checkpatch.pl --file mode; add warning; add --file-force

From: Andy Whitcroft
Date: Mon Jan 28 2008 - 09:59:20 EST


On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:

> Deprecate checkpatch.pl --file mode; add warning; add --file-force
>
> As discussed on linux-kernel checkpatch.pl only patches for whole
> files have a significant cost. Better such changes should be only
> done together with other changes. Add a explicit warning about
> this; deprecate --file and add a --file-force instead.
>
> Signed-off-by: Andi Kleen <ak@xxxxxxx>

Cirtainly I can see why we want this
warning out there and very much in the submitters face, it just feels a
little heavy handed to make them change option to get the result.

Would not just always appending this message in --file mode always be
just as effective? Perhaps suppressing it with -q, or with some new "i
know what I am doing" option?

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/