Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2controllers

From: Jochen Friedrich
Date: Mon Jan 28 2008 - 13:46:40 EST


Hi Bryan,

>> +
>> + /* register new adapter to i2c module... */
>> +
>> + result = i2c_add_adapter(&cpm->adap);
>
> As I was pointed before, please use the new style i2c driver interface:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=991dee591a99d035796a8c194eb1796cc020e142

AFAIK, the device tree currently doesn't provide an adapter id. If we're going to add this property, this would be
needed on other of_platform i2c drivers, as well.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/