Re: [PATCH] x86: Construct 32 bit boot time page tables in native format.

From: Rafael J. Wysocki
Date: Mon Jan 28 2008 - 17:05:33 EST


On Monday, 28 of January 2008, H. Peter Anvin wrote:
> Rafael J. Wysocki wrote:
> > On Monday, 28 of January 2008, Jeremy Fitzhardinge wrote:
> >> Rafael J. Wysocki wrote:
> >>> Actually, no. We only do that with the kernel code mapping which should be
> >>> safe as long as TLBs are not flushed (and they aren't).
> >>>
> >> Er, what? Assuming the TLB will retain some mappings while you
> >> overwrite the pagetable is a highly dubious prospect. Are you copying
> >> the same values over, or something else?
> >
> > As long as a relocatable kernel is not used to restore a non-relocatable one
> > (or vice versa), we're copying the same values over.
> >
>
> So that case is deliberately considered broken?

Not deliberately, but the fix I had caused a regression. It's just a pending
issue.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/