Re: [patch 1/6] mmu_notifier: Core code

[Avi Kivity]

Christoph Lameter wrote:
> On Tue, 29 Jan 2008, Andrea Arcangeli wrote:
>
>   
> > > +	struct mmu_notifier_head mmu_notifier; /* MMU notifier list */
> > >  };
> > >       
> > Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a
> > regression (a minor one though).
> >     
>
> Andrew does not like #ifdefs and it makes it possible to verify calling 
> conventions if !CONFIG_MMU_NOTIFIER.
>
>   

You could define mmu_notifier_head as an empty struct in that case.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/