x86: Why have __copy_from_user_ll_nocache* been exported?

From: Adrian Bunk
Date: Thu Jan 31 2008 - 15:14:11 EST


A commit that does nothing except for adding two unused EXPORT_SYMBOL's.

Without any rationale why they should be exported.

And that from a person who on the other hand wants to introduce
(and tries to force on other people) deprecation periods for unused
EXPORT_SYMBOL's.

Can we please get this reverted quickly?

TIA
Adrian


commit 914c82694cadbab511f2aee8a59c89be2938bace
Author: Andrew Morton <akpm@xxxxxxxx>
Date: Wed Jan 30 23:27:57 2008 +0100

x86: export copy_from_user_ll_nocache[_nozero]

Cc: Neil Brown <neilb@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

diff --git a/arch/x86/lib/usercopy_32.c b/arch/x86/lib/usercopy_32.c
index 8bab2b2..9c4ffd5 100644
--- a/arch/x86/lib/usercopy_32.c
+++ b/arch/x86/lib/usercopy_32.c
@@ -817,6 +817,7 @@ unsigned long __copy_from_user_ll_nocache(void *to, const void __user *from,
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache);

unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *from,
unsigned long n)
@@ -831,6 +832,7 @@ unsigned long __copy_from_user_ll_nocache_nozero(void *to, const void __user *fr
#endif
return n;
}
+EXPORT_SYMBOL(__copy_from_user_ll_nocache_nozero);

/**
* copy_to_user: - Copy a block of data into user space.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/